verbetering van rectangles

exercise_rectangles.js

@@ -1,32 +1,49 @@
 function makeLine(size) {
-	let li = "";
-	for (let i = 1; i <= size; i++) {
-		li += "#";
+	let line = "";
+	for (let i = 0; i < size; i++) {
+		line += "#";
 	}
-	return li
+	return line
 }
 
 console.log(makeLine(5));
 
 
 function makeSquare(size) {
-	let sq = "";
-	for (let i = 1; i <= size; i++) {
-		sq += '\n' + makeLine(size);
+	let square = "";
+	for (let i = 0; i < size; i++) {
+		square += makeLine(size) + "\n";
 	}
-	return sq
+	return square.trim();
 }
 
-console.log(makeSquare(2));
+console.log(makeSquare(2) + "\n");
 
 
 function makeRectangle(width, height) {
-	let re = "";
+
+	height = height === undefined ? width : height;
+
+	let rectangle = "";
 	for (let i = 0; i < height; i++) {
-		re += "\n" + makeLine(width);
+		rectangle += makeLine(width) + "\n";
 	}
-	return re;
+	return rectangle.trim();
 }
 
 
-console.log(makeRectangle(2, 3));
+
+/* function makeRectangle(width, height = width) {
+
+	height = height === undefined ? width : height;
+
+	let rectangle = "";
+	for (let i = 0; i < height; i++) {
+		rectangle += makeLine(width) + "\n";
+	}
+	return rectangle.trim();
+} */
+
+
+
+console.log(makeRectangle(2));